Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ESLint updates [DUE 9/30] #3189

Closed
6 tasks
Tracked by #137
patphongs opened this issue Sep 20, 2019 · 5 comments
Closed
6 tasks
Tracked by #137

Test ESLint updates [DUE 9/30] #3189

patphongs opened this issue Sep 20, 2019 · 5 comments
Assignees
Milestone

Comments

@patphongs
Copy link
Member

patphongs commented Sep 20, 2019

The ESLint package was updated on the CMS and needs to be tested some to make sure things are functioning as expected. PR that was merged is located here: #3126

https://fec-stage-proxy.app.cloud.gov

Things to do for testing:

  • Check JavaScript modules across the site.
    • datatables
    • glossary
    • feedback box
    • candidate, election, and committee profile pages
    • Visualizations: WCCF, aggregate totals, candidate totals
    • Check other interactive / dynamic features
@patphongs patphongs added this to the Sprint 10.2 milestone Sep 20, 2019
@patphongs patphongs changed the title Test ESLint updates Test ESLint updates [DUE 9/30] Sep 20, 2019
@djgarr
Copy link
Contributor

djgarr commented Sep 26, 2019

Doing a spot check of various areas. So far no big issues (one broken image on the Statutes page that I submitted feedback for). CAPTCHA submissions require twice verification (ie once you get through the initial CAPTCHA images, it asks for a second round).

@djgarr
Copy link
Contributor

djgarr commented Sep 26, 2019

Everything seems to be working properly. Will do some more spot checking tomorrow

@djgarr
Copy link
Contributor

djgarr commented Sep 27, 2019

the link to the AOs doesn't work. getting a "server error" message when clicking on the link

@djgarr
Copy link
Contributor

djgarr commented Sep 27, 2019

everything else looks good

@patphongs
Copy link
Member Author

Thank you @djgarr for testing! AOs weren't working on our staging environment since we had to switch some API keys around. Things are functioning ok now. Since there were no other errors in your testing, I'll close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants