Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk: Low] Regular Expression Denial of Service in braces #3226

Closed
2 tasks
Tracked by #137
jason-upchurch opened this issue Oct 2, 2019 · 4 comments
Closed
2 tasks
Tracked by #137

[Snyk: Low] Regular Expression Denial of Service in braces #3226

jason-upchurch opened this issue Oct 2, 2019 · 4 comments

Comments

@jason-upchurch
Copy link
Contributor

jason-upchurch commented Oct 2, 2019

Summary

Low severity vulnerability found in braces
Description: Regular Expression Denial of Service (ReDoS)
Info: https://snyk.io/vuln/npm:braces:20180219
Introduced through: nswatch@0.2.0
From: nswatch@0.2.0 > chokidar@1.7.0 > anymatch@1.3.2 > micromatch@2.3.11 > braces@1.8.5
Fixed in: 2.3.1

Completion criteria:

  • Determine whether there is a remediation path available for this issue.
  • Identify next steps as appropriate.
@jason-upchurch jason-upchurch added the Security: low Remediate within 90 days label Oct 2, 2019
@jason-upchurch jason-upchurch added this to the Sprint 10.6 milestone Oct 2, 2019
@rfultz
Copy link
Contributor

rfultz commented Nov 22, 2019

This is a dev dependency for us.

We're using several versions of braces but the version is question is being used by descendants of nswatch. nswatch is invoked when we run npm run watch so it's only used when we want our build process to watch our files and rebuild the project whenever we save a js, css, or hbs file. nswatch hasn't been updated in over a year and is still on version 0.2.0.

  • braces@1.8.5 is the most recent v1; upgrading to 2 would require an update to micromatch.
  • micromatch@2.3.11 is the most recent v2; upgrading to 3 would require an update to anymatch.
  • anymatch@1.3.2 is the most recent v1; upgrading to 2 would require an update to chokidar.
  • chokidar@1.7.0 is the most recent v1; upgrading to 2 would require an update to nswatch.
  • nswatch@0.2.0 is the most recent—there is no update.

There's still no remediation but it's a very low vulnerability for us. I can't imagine how someone might use a DDOS against our local machines while we're watching files to change while we're working on them.

@jason-upchurch
Copy link
Contributor Author

micromatch/anymatch#26 resolves the upstream micromatch

@jason-upchurch
Copy link
Contributor Author

Hoping to resolve via PR egoist/nswatch#10

@jason-upchurch jason-upchurch self-assigned this Nov 27, 2019
@JonellaCulmer JonellaCulmer changed the title [Snyk: Low] Regular Expression Denial of Service in braces (Due 12/31/2019) [Snyk: Low] Regular Expression Denial of Service in braces Dec 2, 2019
@JonellaCulmer JonellaCulmer removed the Security: low Remediate within 90 days label Dec 2, 2019
@JonellaCulmer JonellaCulmer removed this from the Sprint 10.6 milestone Dec 2, 2019
@lbeaufort
Copy link
Member

Closing because this isn't a vulnerability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants