Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordions for data filters double count #3465

Open
1 task
Tracked by #137
patphongs opened this issue Jan 15, 2020 · 2 comments
Open
1 task
Tracked by #137

Accordions for data filters double count #3465

patphongs opened this issue Jan 15, 2020 · 2 comments

Comments

@patphongs
Copy link
Member

patphongs commented Jan 15, 2020

Summary

Accordions for data filters double count when adding the same accordion filters from processed filters to raw filters.

Related PR that may help to fix double counted filters: #2468

This depicts how an accordion double counts the raw data filters for candidate mentioned.

Screen Shot 2020-01-15 at 1 46 18 PM

Related issues

List any relevant related issue(s)

Completion criteria

  • make sure the filters don't double count when toggling between raw and processed data.
@patphongs
Copy link
Member Author

This PR helps to fix filter counts: #3532. But I have not had a chance to fix failing tests or fix the accordion filter counts when toggling between processed and raw data.

@patphongs patphongs modified the milestones: Sprint 11.4, Sprint 11.6 Feb 14, 2020
@patphongs
Copy link
Member Author

Accordion still appears to double count when trying to toggle between processed and raw. I am still trying to figure out why that is happening.

@patphongs patphongs removed their assignment Mar 13, 2020
@patphongs patphongs removed this from the Sprint 11.6 milestone Mar 13, 2020
@JonellaCulmer JonellaCulmer added this to the Sprint 12.1 milestone Mar 13, 2020
@JonellaCulmer JonellaCulmer removed this from the Sprint 12.1 milestone Apr 6, 2020
@JonellaCulmer JonellaCulmer added this to the Sprint 13.4 milestone Jul 15, 2020
@patphongs patphongs modified the milestones: Sprint 13.4, Sprint 13.5 Aug 31, 2020
@patphongs patphongs modified the milestones: Sprint 13.5, Sprint 13.6 Sep 9, 2020
@jason-upchurch jason-upchurch removed this from the PI 13 innovation 1 milestone Oct 13, 2020
@jason-upchurch jason-upchurch added this to the Sprint 13.8 milestone Oct 13, 2020
@patphongs patphongs modified the milestones: Sprint 13.8, PI 13 innovation 2 and PI 14 planning Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ❄️ Icebox
Development

Successfully merging a pull request may close this issue.

5 participants