Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD contact page goes down when servicenow API is down #3718

Closed
1 task
Tracked by #137
lbeaufort opened this issue Apr 27, 2020 · 1 comment · Fixed by #3933
Closed
1 task
Tracked by #137

RAD contact page goes down when servicenow API is down #3718

lbeaufort opened this issue Apr 27, 2020 · 1 comment · Fixed by #3933

Comments

@lbeaufort
Copy link
Member

lbeaufort commented Apr 27, 2020

The RAD contact page goes down when ServiceNow API is down. We should fall back to "look up your analyst" when we can't get to the ServiceNow API

How to test:

Example error:

2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR   File "/home/vcap/deps/0/python/lib/python3.6/site-packages/django/core/handlers/exception.py", line 34, in inner
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR     response = get_response(request)
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR   File "/home/vcap/deps/0/python/lib/python3.6/site-packages/django/core/handlers/base.py", line 115, in _get_response
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR     response = self.process_exception_by_middleware(e, request)
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR   File "/home/vcap/deps/0/python/lib/python3.6/site-packages/django/core/handlers/base.py", line 113, in _get_response
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR     response = wrapped_callback(request, *callback_args, **callback_kwargs)
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR   File "/home/vcap/app/fec/home/views.py", line 268, in contact_rad
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR     form = ContactRAD()
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR   File "/home/vcap/app/fec/fec/forms.py", line 17, in __init__
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR     category_options = [('', 'Choose a subject')] + form_categories()
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR   File "/home/vcap/app/fec/fec/forms.py", line 69, in form_categories
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR     raw_categories = fetch_categories()
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR   File "/home/vcap/app/fec/fec/forms.py", line 58, in fetch_categories
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR     return r.json()['result']
   2020-04-27T10:25:32.30-0400 [APP/PROC/WEB/2] ERR KeyError: 'result'
  • Add logging when unable to connect to ServiceNow. Slack alert? How to not send thousands of these? Maybe just a Pingdom alert for servicenow api instead of the contact page itself.
@bmathesonFEC
Copy link
Contributor

@patphongs does your testing with the RAD contact page have anything to do with this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants