Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk: Med] Prototype Pollution (Due 07/05/2020) #3740

Closed
1 task done
Tracked by #137
fec-jli opened this issue May 6, 2020 · 6 comments · Fixed by #3890
Closed
1 task done
Tracked by #137

[Snyk: Med] Prototype Pollution (Due 07/05/2020) #3740

fec-jli opened this issue May 6, 2020 · 6 comments · Fixed by #3890
Assignees
Labels
Security: moderate Remediate within 60 days

Comments

@fec-jli
Copy link
Contributor

fec-jli commented May 6, 2020

Summary

Medium severity vulnerability found
Description: Prototype Pollution
Info: https://app.snyk.io/vuln/SNYK-JS-LODASH-567746
Prototype Pollution is a vulnerability affecting JavaScript.

Remediation: There is no fixed version for lodash.

Completion criteria:

  • Check to see if there's a remediation path for this
  • [ ]Consider/document alternatives or workaround to solve this security issue and do that thing
@pkfec
Copy link
Contributor

pkfec commented Jun 3, 2020

  1. Tried updating lodash to v4.17.15 in package.json
  2. deleted the package-lock.json from local : rm - rf package-lock.json
  3. deleted the node_modules from local : rm - rf node_modules/
  4. installed npm pkgs again : npm i and npm run build
  5. from CLI ran : synk test
  6. proto type pollution vulnerability STILL exists on fec-cms repo.

The latest version of lodash pkg still do not have the patch/remediation for Prototype Pollution yet. At this point there is nothing i can do and wait for the PATCH to be released here (https://app.snyk.io/vuln/SNYK-JS-LODASH-567746)

@pkfec
Copy link
Contributor

pkfec commented Jun 12, 2020

Patch yet to be release for Lodash v4.17.15. Until then moving this ticket to blocked section.

@lbeaufort
Copy link
Member

It looks like a fix was made but a release still needs to be pushed: https://github.com/lodash/lodash/issues/4837

@pkfec
Copy link
Contributor

pkfec commented Jul 6, 2020

Notified security team that this issue is BLOCKED until the LODASH package is fixed in a later version.
See here: https://app.snyk.io/vuln/SNYK-JS-LODASH-567746

@lbeaufort
Copy link
Member

@pkfec
Copy link
Contributor

pkfec commented Jul 9, 2020

Updated lodash pkg to the latest v4.17.19. And a PR #3890 is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security: moderate Remediate within 60 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants