Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for MURs that are missing documents #3772

Closed
1 task done
Tracked by #137
JonellaCulmer opened this issue May 19, 2020 · 3 comments · Fixed by #3813
Closed
1 task done
Tracked by #137

Error handling for MURs that are missing documents #3772

JonellaCulmer opened this issue May 19, 2020 · 3 comments · Fixed by #3813
Assignees
Milestone

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented May 19, 2020

What we're after:
To catch missing MUR documents in the future, we need to incorporate better error handling and alerting when an error occurs.

For more details:
This is related to fecgov/openFEC#4361
and fecgov/openFEC#4364

Question:

  • Do all MURs have documents

Completion criteria:

  • Front-end should show a warning message on a MUR when there are missing documents, but the page should still load.
@patphongs
Copy link
Member

@JonellaCulmer @dorothyyeager I need some help as to what we should show when there are no MUR documents due to a failed document loading issue in the API. This is what I have so far, could you please help to refine it?

Screen Shot 2020-06-03 at 5 30 30 PM

@JonellaCulmer
Copy link
Contributor Author

@patphongs We have draft language below which is not much different from what you have there.

We're wondering though, what kind of error has occurred? We want to be specific - server error? Internal error? Yada yada. Also, are these just for new MURs or can this happen to older MURs and the documents "disappear" and need to be fixed?

What we have so far:
Sorry, there was a problem loading these documents. Please try again later.

cc: @dorothyyeager

@patphongs
Copy link
Member

@JonellaCulmer @dorothyyeager Typically MUR document problems tend to happen when the documents failed to load when re-indexed in ElasticSearch. We noticed last time this happened that it did not effect every MUR, but probably half. So I think the error message that you have works perfectly, since it talks about a problem with loading documents. I'll update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants