Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language to filters with 10 item limits #3790

Closed
2 tasks done
Tracked by #137
JonellaCulmer opened this issue May 28, 2020 · 5 comments
Closed
2 tasks done
Tracked by #137

Add language to filters with 10 item limits #3790

JonellaCulmer opened this issue May 28, 2020 · 5 comments
Assignees
Milestone

Comments

@JonellaCulmer
Copy link
Contributor

JonellaCulmer commented May 28, 2020

What we're after: As work moves forward with the 10 item limitation for schedule A, B, and E datatables, we need to make it clear that a limitation exists so users are not "penalized" and confronted with an error before knowing there was a limit.

Completion criteria:

@JonellaCulmer JonellaCulmer self-assigned this May 28, 2020
@JonellaCulmer JonellaCulmer added this to the Sprint 12.5 milestone May 28, 2020
@JonellaCulmer
Copy link
Contributor Author

JonellaCulmer commented Jun 1, 2020

First draft with 10 item limit language added with @dorothyyeager's help.

Let me know if you have any concerns/feedback @patphongs and @dorothyyeager.
I also moved up the larger blurb associated with the time period.

@dorothyyeager What do you think about the addition of the work "contributor" to the names and IDs field? All of those fields are "contributor" details, so I'm curious what you think about the addition there, but nowhere else.

Screen Shot 2020-06-01 at 10 01 21 AM

@patphongs
Copy link
Member

@JonellaCulmer These look good to me, the only thing that we can't do is a line break for the helper text. So for the Occupation field, there is already helper text there. We can only add "Limit 10 occupations" to that helper text and can't make it a line break.

@JonellaCulmer
Copy link
Contributor Author

@patphongs Thanks for clarifying that. That's just how the text wrapped for me. No need to include a line break.

@patphongs
Copy link
Member

These labels have been applied within this PR: #3780 (comment).

@patphongs
Copy link
Member

This work has already been merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants