Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate profile page: 404 when navigating directly to 2-year transaction period if fec_cycles_in_election null #4040

Closed
Tracked by #137
patphongs opened this issue Sep 14, 2020 · 1 comment

Comments

@patphongs
Copy link
Member

patphongs commented Sep 14, 2020

Summary

Navigating to the 2-year transaction period directly on a candidate profile page without fec_cycles_in_election will result in a 404.

How to Reproduce

  1. Go to this URL and it will 404: https://www.fec.gov/data/candidate/S6FL00335/?cycle=2014&election_full=false

What should have happened?

The user should not get a 404 when doing this. Consider a redirect to the main All years slice when this happens. Example https://www.fec.gov/data/candidate/S6FL00335/?cycle=2014&election_full=false redirects to https://www.fec.gov/data/candidate/S6FL00335/. By default, the main candidate URL without query params is election_full=true and cycle=[max_cycle]

Screenshots

Screen Shot 2020-09-14 at 10 37 33 AM

Related PR

#4034

@patphongs patphongs added the Bug label Sep 14, 2020
@patphongs patphongs changed the title Candidate profile page: 404 on 2-year transaction period if candidate Candidate profile page: 404 when navigating directly to 2-year transaction period if fec_cycles_in_election null Sep 14, 2020
@JonellaCulmer JonellaCulmer added this to the Sprint 14.2 milestone Mar 2, 2021
@JonellaCulmer
Copy link
Contributor

De-prioritizing this issue for now. Not easy to get to that broken page. Navigating through normal methods throughout the site gets the user to the right place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants