Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance for cache calls (#2749) & turn it on #2913

Closed
1 task
jwchumley opened this issue Feb 9, 2018 · 5 comments
Closed
1 task

Improve performance for cache calls (#2749) & turn it on #2913

jwchumley opened this issue Feb 9, 2018 · 5 comments
Assignees
Milestone

Comments

@jwchumley
Copy link
Contributor

jwchumley commented Feb 9, 2018

What we're after:

The work to cache calls was completed but is not performant so we need to figure out why and improve performance and put it into production

Detailed documentation in #2749

  • Research to resolve performance issue
@PaulClark2 PaulClark2 added this to the Sprint 5.1 milestone Feb 9, 2018
@pkfec
Copy link
Contributor

pkfec commented Feb 16, 2018

For cached calls, we observed that the requests are being cached before the request is completed. That added a big performance hit on the website. It looks like we no longer can use the after_request decorator.
Thinking of any alternatives like the celery worker could be feasible. Started some research work on how to use celery worker for caching the calls.

@pkfec
Copy link
Contributor

pkfec commented Feb 16, 2018

To do's #

@pkfec
Copy link
Contributor

pkfec commented Feb 21, 2018

@LindsayYoung : How do i configure the celery worker/beat to cache the requests in real time?

@AmyKort AmyKort modified the milestones: Sprint 5.1, Sprint 5.2 Feb 27, 2018
@pkfec pkfec added this to the Sprint 5.2 milestone Mar 15, 2018
@pkfec
Copy link
Contributor

pkfec commented Mar 15, 2018

Save and Retrieve Cache calls PR is merged to develop.
TODO :# Run the load test (locust) to make sure it doesn't impact the application performance and is working as expected in Dev and or in Stage once this change gets deployed.

@AmyKort
Copy link

AmyKort commented Mar 16, 2018

I'm going to close this issue and make a new ticket for the load testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants