Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[High] fecgov/openFEC:data/flyway/build.gradle - need a fix by Apr. 28, 2019 #3654

Closed
8 tasks done
qqss88 opened this issue Mar 28, 2019 · 3 comments · Fixed by #3676
Closed
8 tasks done

[High] fecgov/openFEC:data/flyway/build.gradle - need a fix by Apr. 28, 2019 #3654

qqss88 opened this issue Mar 28, 2019 · 3 comments · Fixed by #3676

Comments

@qqss88
Copy link
Contributor

qqss88 commented Mar 28, 2019

Overview:
org.postgresql:postgresql is a Java JDBC 4.2 (JRE 8+) driver for PostgreSQL database.

Affected versions of this package are vulnerable to Man-in-the-Middle (MitM). It was possible to provide an SSL Factory and not check the host name if a host name verifier was not provided to the driver.
Man-in-the-Middle (MitM)
https://app.snyk.io/org/fecgov/project/e6c155e9-f0ac-4a49-98fa-83c24f5b74b3/

Vulnerable module: org.postgresql:postgresql

Introduced through: org.flywaydb:flyway-commandline@5.1.3

Detailed paths :
Introduced through: project@0.0.0 › org.flywaydb:flyway-commandline@5.1.3 › org.postgresql:postgresql@42.2.2.jre6

Remediation : Upgrade org.postgresql:postgresql to version 42.2.5 or higher.

  • Install version 5.2.4 of Flyway
  • Update Flyway version to 5.2.4 here
  • Update Flyway version to 5.2.4 here
  • Update README with new version instructions
  • Update team google doc instructions
  • Test with manual deploy - make sure flyway checks to see if there are any new migrations
  • Test migration with headless app (look for flyway-independent-migration) As a team we decided we could skip this step since we tested it with the last upgrade. We find manual deploy to be sufficient.
  • Give devs instructions on updating local
@JonellaCulmer JonellaCulmer added this to the Sprint 8.5 milestone Mar 28, 2019
@JonellaCulmer JonellaCulmer changed the title [High]fecgov/openFEC:data/flyway/build.gradle - need a fix by 20190428 [High]fecgov/openFEC:data/flyway/build.gradle - need a fix by Apr. 28, 2019 Mar 29, 2019
@lbeaufort
Copy link
Member

It looks like Currently Flyway version 5.1.3 downloads
flyway-5.1.3/drivers/postgresql-42.2.2.jre6.jar

I'm thinking we might need to upgrade Flyway version, but we need to figure out if that will automatically update the postgresql driver.

@pkfec
Copy link
Contributor

pkfec commented Apr 4, 2019

@lbeaufort I have installed the latest version of flyway 5.2.4 and ran the migrations against my local test db. This latest version of flyway comes with an upgraded postgressql-42.2.5.jre6.jar. Didnt run into any issues on my local. Hope this helps.

Screen Shot 2019-04-04 at 12 01 57 PM

@lbeaufort
Copy link
Member

That is great, thank you so much @pkfec!

@lbeaufort lbeaufort changed the title [High]fecgov/openFEC:data/flyway/build.gradle - need a fix by Apr. 28, 2019 [High] fecgov/openFEC:data/flyway/build.gradle - need a fix by Apr. 28, 2019 Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants