Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk: High]dicer Denial of Service (DoS) (06/24/2022) [No remediation path available] #5146

Closed
1 task done
cnlucas opened this issue May 25, 2022 · 3 comments · Fixed by #5178
Closed
1 task done
Assignees
Labels
Security: general General security concern or issue Security: high Remediate within 30 days
Milestone

Comments

@cnlucas
Copy link
Member

cnlucas commented May 25, 2022

What we’re after

Detailed paths

Introduced through: openfec@1.0.0 › swagger-tools@0.10.4 › multer@1.4.4 › busboy@0.2.14 › dicer@0.2.5
Fix: No remediation path available. 

Overview

Affected versions of this package are vulnerable to Denial of Service (DoS). A malicious attacker can send a modified form to server, and crash the nodejs service. An attacker could sent the payload again and again so that the service continuously crashes.

Completion criteria

(What does the end state look like - as long as this task(s) is done, this work is complete)

  • Check for remediation path and if not, we need to inform Security team
@cnlucas cnlucas added Needs refinement Security: high Remediate within 30 days Security: general General security concern or issue labels May 25, 2022
@cnlucas cnlucas added this to the Sprint 18.3 milestone May 25, 2022
@cnlucas cnlucas modified the milestones: Sprint 18.3, Sprint 18.4 Jun 13, 2022
@cnlucas
Copy link
Member Author

cnlucas commented Jun 13, 2022

No remediation path still, moving forward

@pkfec
Copy link
Contributor

pkfec commented Jun 23, 2022

@cnlucas swagger-tools is the package that needs to be updated to resolve this issue. swagger-tools was last updated 4 years ago (2018) is what the website says: https://www.npmjs.com/package/swagger-tools

You may want to check in our code if there are any references to dicer package (i believe we are not using at all). if not, we can report and close this issue

cc @patphongs @fec-jli

@cnlucas
Copy link
Member Author

cnlucas commented Jun 23, 2022

@pkfec I have alerted the security team about this issue. I only find instances in package-lock?

[Edited with new info] I tried upgrading multer and busboy, but without taking out swagger-tools nothing gets rid of the vulnerability. I tried just pulling out swagger-tools and everything is working fine. I'm currently trying to figure out how we are using it, because without it we remove all of our current vulnerabilities. There's no good option to replace everything it does, but if we are using a piece of it there are good options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security: general General security concern or issue Security: high Remediate within 30 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants