Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading Error Message for No Results #979

Closed
patphongs opened this issue Jun 16, 2015 · 2 comments
Closed

Misleading Error Message for No Results #979

patphongs opened this issue Jun 16, 2015 · 2 comments
Labels
Bug

Comments

@patphongs
Copy link
Member

Reproduce by:

  1. Search by Candidate, type Obama
  2. Select Obama, Barack H for House
    screen shot 2015-06-15 at 10 04 54 pm
  3. No Results screen returns "None election cycle", which is confusing. Would expect the text to reference the selected election cycle or some alternative text.
    screen shot 2015-06-15 at 9 52 54 pm
@patphongs patphongs added the Bug label Jun 16, 2015
@jmcarp jmcarp self-assigned this Jun 16, 2015
@jmcarp
Copy link
Contributor

jmcarp commented Jun 16, 2015

Thanks @patphongs for reporting! This has been fixed in fecgov/openFEC-web-app#275. The fix will be deployed soon.

@LindsayYoung
Copy link
Contributor

This formats no results nicely but we need to fix the underlying data issue, I am documenting that separately in issue #986.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmcarp @LindsayYoung @patphongs