Events

[fed1k]

Hi Code Reviewer. Followed followings:

* Copy the files calculate.js and operate.js into a logic/ directory in the project.
* Analyze the files calculate.js and operate.js.
* Import the files in Calculator component.
* Implement the event handlers use the math logic from calculate.js and operate.js in React component.
* Test the app in the browser. It is able to perform math operations.

Happy Reviewing👏

[rloterh]

Hi Firdavs,

You did extremely great on this project! 👏 👏
There are however a few issues that you still need to work on to go to the next project but you are almost there! 🚦 🚦 🚦

Highlights 👍

• Descriptive Pull Request
• Good commit messages
• Project is set up correctly
• Good ReadMe
• No linter errors

Required Changes ♻️

Kindly check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Kindly check the comments marked [OPTIONAL] under the review.


Cheers and Happy coding!👏 💻 🍷

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have 1 more limited review per this project. If you think that the code review was not fair, you can request a second opinion using this form.

[rloterh]

• OPTIONAL
  There are commented code blocks found in your code. Kindly endeavor to remove all commented code blocks from your code before pushing it to the repository so as to keep your code well organized.

[rloterh]

• Your calculator app is failing upon performing an operation involving the division operator. For instance, when I try to compute 9 / 9 it returns a blank screen instead of 1, unlike performing a calculation with the other operators. Kindly ensure to improve upon this aspect.

[fed1k]

@rloterh Hi I realized that and fixed it like 20 minutes ago

[fed1k]

@rloterh if you check my last commit it is working

[rloterh]

@fed1k
Actually, no further changes need to be committed/ pushed once your project is submitted for review, except after the review is complete. Else, it is difficult for reviewers to notice the later changes. I apologize, I actually couldn't notice your changes as I happen to have cloned your project for review before you updated your code.

[rloterh]

@fed1k
In case you've implemented the requested changes, kindly go ahead to submit your project for a second review.
Cheers! 😃

[fed1k]

Ohh okay I got it. That is not problem I will just remove commented code and resubmit again. Thanks for reviewing. Have a nice time.

[fed1k]

@rloterh Thanks again for the code review

[mmsesay]

Hi @fed1k,

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.