Allow purging (Purge API) / don't leak on dropping producer #520
Conversation
Resolves fede1024#518 **What it does:** - Purges producer on drop - Updates bindgen script to more recent bindgen version - Sets the parameter that makes macro constants signed (because that's how they are generally used in librdkafka)
|
Could use a ci run as well 🙂 |
|
This is ready. I went ahead and pulled the trigger on removing the It seems similarly unnecessary on the |
Since you suggested that I dedicate time to implementing this... when could I hope for this to be reviewed? |
| --raw-line "use num_enum::TryFromPrimitive;" \ | ||
| --default-macro-constant-type "signed" \ |
There was a problem hiding this comment.
Was this important for this PR? Or just avoiding an as i32 somewhere?
There was a problem hiding this comment.
It was avoiding as i32 in my code as well as in existing code. Overall this seems to be how macro constants are used in librdkafka, so that seems to be the right way to represent these.
| /// Don't wait for background thread queue purging to finish. | ||
| const NON_BLOCKING = rdkafka_sys::RD_KAFKA_PURGE_F_NON_BLOCKING; | ||
| } | ||
| } |
There was a problem hiding this comment.
I feel like it would be Rust-ier to use a PurgeConfig struct here with queue(bool), in_flight(bool), and non_blocking(bool) methods. No particular need to save the two bytes. Also avoids the dependency on the bitflags crate, which idk someone will probably care about. (We get a lot of PRs to minimize crate dependencies.)
There was a problem hiding this comment.
So that is something I initially considered and I changed my mind twice about it.
And here is one more ^^
Done in 37e3180
|
@Ten0 we're preparing a release of |
Conflicts: changelog.md
|
done |
Resolves #518
What it does:
Todo: