Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue after status bar animation ends #4

Closed
muhammadnomany25 opened this issue Jun 28, 2020 · 8 comments
Closed

Issue after status bar animation ends #4

muhammadnomany25 opened this issue Jun 28, 2020 · 8 comments

Comments

@muhammadnomany25
Copy link

On Android 7, after animation of staus bar ends, the status bar changes to WHITE color, not to the original status bar color

@fede87
Copy link
Owner

fede87 commented Aug 11, 2020

Hi, thanks for the report.
I have tested with android 7 on emulator, no issue found, can you gave me more details?
Are you providing the alert color with the function withAlertColor(color) on the builder object?
You can achieve transparent effect providing same color used in the theme for the status bar.

@nestoleh
Copy link
Contributor

nestoleh commented Dec 3, 2020

Hi, I think @muhammadnomany25 meant status bar text and icons color, not the background. I have the same behavior on Android 10 (Xiaomi Mi Mix 3). Text of toolbar always white after StatusBarAlert showing and hiding, even if it was dark before and set as dark for activity theme.

@nestoleh
Copy link
Contributor

nestoleh commented Dec 4, 2020

I added a pull request #5 to keep UI visibility flags, that will help to keep the status bar content color, @fede87 can you please look closer at it?

@fede87
Copy link
Owner

fede87 commented Dec 25, 2020

Thanks @nestoleh for your contribution, I tried your changes but unfortunately if the alert view is shown when the status is not in low profile mode, when the alert view is going to be hidden the status bar will not reset its status to normal.
If you are looking to keep the status bar in the previous state if you show the alert view and the status bar is in low profile or immersive mode yet, the flag should be cached before showing the alert and reset after the hide animation. I will work on it in a further release.

@nestoleh
Copy link
Contributor

Hi @fede87, thanks for the response. It was my bad, I tested these changes on a Xiaomi device, and looks like MIUI doesn't work correctly with low profile mode (status bar never changed in low profile). Looks like I know how to fix this, we just need to remove the "low profile" flag on alert hide. I added new pull request #6 with these changes and tested it on the real device and emulators, for me it works correctly.

@fede87
Copy link
Owner

fede87 commented Dec 25, 2020

Thanks @nestoleh again for your contribution and your quick fix!
I've tested and merged your pull request.

@nestoleh
Copy link
Contributor

Great! Are you planning a new release in the near future?

@fede87
Copy link
Owner

fede87 commented Dec 25, 2020

@nestoleh I'm going to release it today, I've also added a couple of features to change text and progress bar colors.

@fede87 fede87 closed this as completed Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants