Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid support? #177

Closed
jluttine opened this issue Jun 11, 2015 · 22 comments
Closed

F-Droid support? #177

jluttine opened this issue Jun 11, 2015 · 22 comments

Comments

@jluttine
Copy link

jluttine commented Jun 11, 2015

I would love to see Omni Notes on F-Droid. Would it be possible to make the required changes to Omni Notes?

Some references on the topic:
#20 (comment)
https://f-droid.org/forums/topic/omni-notes/
https://f-droid.org/wiki/page/it.feio.android.omninotes

@federicoiosue
Copy link
Owner

It's not possible at the moment due toa couple of dependencies I use at compile time that are not open source (analytics and play services)

@Mosrite
Copy link

Mosrite commented Jun 14, 2015

Are there plans to change this in the long run? What are Play Services used for?

@federicoiosue
Copy link
Owner

@Mosrite actually I'm not planning to make any changes on this side.

Due to the fact that ON has begun a quite complex application all my attempts to avoid a deep dependecy with Google's third party libraries are now slowing the development.

Play services are now used just for some internal checks but moving in their direction for what concerns geolocation and user authentication could be really make my life easier.

@federicoiosue
Copy link
Owner

@Mosrite, @jluttine the newcoming 5.1 Beta will be released as FOSS.

I'd like to move closed source dependencies to external apps to be plugged-in just under special cicrumstances.

@Mosrite
Copy link

Mosrite commented Jun 22, 2015

That's awesome, thanks! Maybe we'll see ON on F-Droid after all?

@federicoiosue
Copy link
Owner

This will actually require some time due to the fact that I'll have to develop all the needed code and make it stable before I can move it to the master branch (that F-Droid's guys will use to compile the app and distribute on their portal/mobile app)

@jluttine
Copy link
Author

Really great news! :) Thanks a lot!

@AnderRasoVazquez
Copy link

Thanks for considering F-droid! =D

@federicoiosue
Copy link
Owner

A new request to be distrituited through F-Droid has been posted (https://f-droid.org/forums/topic/omni-notes/#post-16907).
Let's wait for answer.

@r0bbie
Copy link

r0bbie commented May 3, 2016

Any update on this? Just to add myself to the list, I'd love to see Omni-Notes on F-Droid!

@federicoiosue
Copy link
Owner

federicoiosue commented May 3, 2016

No way, at least for now: https://f-droid.org/forums/topic/omni-notes/

@github-user-1
Copy link

Just wanted to throw in that I as well would really like to see ON on F-Droid. Keep on the good work and I keep my fingers crossed it will be possible with F-Droid at some point in time!

@r0bbie
Copy link

r0bbie commented Jun 6, 2016

@federicoiosue thanks for all your work so far towards getting Omni-Notes onto F-Droid! Real shame there's currently still a blocking issue.

Is the only blocker now the use of jitpack? I see jitpack referenced in some pull requests (f-droid/fdroiddata@367aa58) so perhaps F-Droid's previous issues with jitpack are now resolved?

@federicoiosue
Copy link
Owner

JitPack is a great tool directly connected to ON's source code on GitHub.
They simply perform a build like any Jenkins or similar CI tool does but on a rootless Docker container.

I've understood that the F-Droid policy is to retrieve and locally build any distribuited software's dependency (while for example on TravicCI Omni Notes is built by using compiled dependencies).

I'll give a look asap at the link @r0bbie reported to get more informations.

@relan
Copy link

relan commented Jun 11, 2016

Omni-Notes 5.2.15 still includes a proprietary component: com.google.android.gms:play-services-location (required by io.nlopez.smartlocation:library). That's a show stopper for F-Droid.

@r0bbie
Copy link

r0bbie commented Jun 11, 2016

@federicoiosue if accurate, is there any reason for Omni Notes including this at present?

Seen the update on the forum post that Jitpack is now allowed, which is great news.

@federicoiosue
Copy link
Owner

I've already prepared the script to build Omni Notes using the FDroid framework but I'm having some issues on my machine and few time at the moment to work on that. I'll eventually attach it here, maybe someone has a clean machine that will cause less issues.

For what concerns io.nlopez.smartlocation:library I'm using it because it's a nice wrapper around geolocation code with support for Observers (reactive java).
Actually I'm using its open-source implementation (the same I used before into the app, manually crafted) but from what you're saying it includes closed source code at compile time.
I'll give a look to newer version to see if that's already been implemented, otherwise mi idea is to fork it and prepare a FOSS-compatible version of it.

@qazip
Copy link

qazip commented Nov 1, 2016

Any news regarding this? I would like to see ON on fdroid.

@federicoiosue
Copy link
Owner

federicoiosue commented Jan 26, 2017

@mimf, @r0bbie I've submitted on their new issue tracker: https://gitlab.com/fdroid/rfp/issues/16

@federicoiosue
Copy link
Owner

Omni Notes is now available on F-Droid

@CryptGoat
Copy link

Releases 5.5.3 and 5.5.4 are not available via F-Droid. Looks like those two version weren't detected as latest releases: https://f-droid.org/wiki/page/it.feio.android.omninotes.foss

@federicoiosue
Copy link
Owner

@CryptOwl It's due to #676 and #669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants