Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flymake-shellcheck shouldn't activate when editing RPM .spec files #9

Open
1player opened this issue May 4, 2022 · 0 comments · May be fixed by #10
Open

flymake-shellcheck shouldn't activate when editing RPM .spec files #9

1player opened this issue May 4, 2022 · 0 comments · May be fixed by #10

Comments

@1player
Copy link

1player commented May 4, 2022

I have added flymake-shellcheck-load as a sh-mode-hook as recommended in the documentation, but that mode is loaded for RPM .spec files as well, and they are not supported by shellcheck.

I've changed my configuration to the following:

(add-hook 'sh-mode-hook (lambda ()
                            (unless (eq sh-shell 'rpm)
                              (flymake-shellcheck-load))))

but perhaps this check should be done by flymake-shellcheck-load, or at least documented in the README.

@1player 1player linked a pull request May 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant