Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ob-verb] Request body including multibyte characters cause error #14

Closed
kamoii opened this issue Mar 12, 2020 · 4 comments
Closed

[ob-verb] Request body including multibyte characters cause error #14

kamoii opened this issue Mar 12, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@kamoii
Copy link

kamoii commented Mar 12, 2020

Trying to send a request which includes multibyte characters with ob-verb causes error.

#+begin_src verb
template http://localhost:3000/api
Accept: application/json
Content-Type: application/json; charset=utf-8
#+end_src

#+begin_src verb :wrap src ob-verb-response :op send get-body
post /officer/basic_info/90000000

{ test: "日本語" }
#+end_src

Following message is outputed to *Messages*.

POST request sent to http://localhost:3000/api/officer/basic_info/90000000
url-http-create-request: Multibyte text in HTTP request: POST /api/officer/basic_info/90000000 HTTP/1.1
MIME-Version: 1.0
Connection: keep-alive
Extension: Security/Digest Security/SSL
Host: localhost:3000
Accept-encoding: gzip
Accept: application/json
Content-Type: application/json; charset=utf-8
Content-length: 21

{ test: "日本語" }
@federicotdn
Copy link
Owner

Hi @kamoii, thanks for reporting this. I've managed to reproduce it locally and will look into it.

@federicotdn
Copy link
Owner

Interesting: if I remove the Accept header, it appears to work

@federicotdn
Copy link
Owner

I've pushed a fix to master, please check if it works for you when the next MELPA build picks it up.

@kamoii
Copy link
Author

kamoii commented Mar 13, 2020

@federicotdn Thank you! Installed the latest version, and it works!

@kamoii kamoii closed this as completed Mar 13, 2020
@federicotdn federicotdn added the bug Something isn't working label Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants