Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using actions-rs #1172

Closed
dpc opened this issue Dec 28, 2022 · 4 comments · Fixed by #1529
Closed

Stop using actions-rs #1172

dpc opened this issue Dec 28, 2022 · 4 comments · Fixed by #1529
Labels
good first issue Good for newcomers

Comments

@dpc
Copy link
Contributor

dpc commented Dec 28, 2022

See rust-bitcoin/rust-bitcoin#1509 (comment) . We use actions-rs just in a handful of places, but still we should do the same.
@dpc dpc added the good first issue Good for newcomers label Dec 28, 2022
@oleonardolima
Copy link
Contributor

@dpc I was taking a look at this one, both rust-bitcoin and a bunch of other projects started using the dtolnay/rust-toolchain.

Is the initial idea to do the same and update it to use it? Or there is another alternative that would be good to check too?

@dpc
Copy link
Contributor Author

dpc commented Jan 24, 2023

I think I've seen rust-toolchain being recommended, yes.

@oleonardolima
Copy link
Contributor

Great! I can take a look at this one then.

@oleonardolima oleonardolima mentioned this issue Jan 27, 2023
Merged
@oleonardolima
Copy link
Contributor

@dpc I've created a PR changing the rust-toolchain, would you mind taking a look at it?

@dpc dpc closed this as completed in #1529 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: update to use dtolnay instead of actions-rs oleonardolima/fedimint
2 participants
@dpc @oleonardolima