Use FederationModuleConfigGen to manipulate module configs
#1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step toward modularization, where configs (and anything else about modules) is injected from the outside.
dpc
force-pushed
the
config-gen-fix
branch
2 times, most recently
from
dea9216
to
4e37d8b
Compare
dpc
commented
Dec 29, 2022
| @@ -257,20 +275,31 @@ impl ServerConfig { | |||
| bail!("Peer ids are not indexed from 0"); | |||
| } | |||
|
|
|||
| self.get_module_config::<WalletConfig>("wallet")? | |||
dpc
commented
Dec 29, 2022
| @@ -133,34 +133,37 @@ impl ServerConfigConsensus { | |||
| }) | |||
| .collect(); | |||
|
|
|||
| let modules = vec
|
@jkitman Please let me know if looks OK. |
|
I have confirmed this made add in the social recovery module much easier. @elsirion |
elsirion
approved these changes
Dec 31, 2022
|
Nice, good to get rid of those! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of some hardcodings listing federation modules deep inside generic code, and move toward edges (final binaries), so it's easier to customize/inject new modules.
There's probably a lot more work to do around it, but it's a step towards the goal, I think.