Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indefinite / Long term sessions for release-monitoring.org #952

Closed
kentfredric opened this issue Jul 17, 2020 · 8 comments
Closed

Indefinite / Long term sessions for release-monitoring.org #952

kentfredric opened this issue Jul 17, 2020 · 8 comments
Labels
hacktoberfest Low Priority This ticket has a low priority type.feature New feature

Comments

@kentfredric
Copy link

See also, #340

But 24 hours is still very short, considering most of my "important" tools like:

  • Github
  • Our bugzilla instance

Have literally infinite sessions.

If this is not smart for "everyone", perhaps add a login toggle that extends your session to something like 3 months.

Because as is, my need to change content on rm.o is roughly every 3-4 days in the middle of a mass sweep downstream, and having to re-login before every change is still a thing as a result.

@kentfredric
Copy link
Author

This would also reduce the frequency of being annoyed by bug #913

@Zlopez
Copy link
Contributor

Zlopez commented Jul 17, 2020

I could actually change the session length to indefinite, I don't think this will add any vulnerability exposure. Most of the action still relies on CSRF token and you could still log out if you need to.

@Zlopez Zlopez added type.feature New feature Low Priority This ticket has a low priority labels Jul 17, 2020
@Zlopez
Copy link
Contributor

Zlopez commented Jul 17, 2020

Looking at the Flask documentation, there is probably no way to set indefinite session time. But I can set it to one month or week if needed.
Another issue I noticed is that the session.permanent is not set anywhere, so it looks like the Anitya is using the standard 20 minutes session life regardless of what is set.

I will mark this as enhancement.

@glensc
Copy link
Contributor

glensc commented Feb 24, 2021

Seems the previous 24-hour session is also gone (reverted?):

@romulasry
Copy link

Yes, could you set a cookie so it doesn't logout when your close the browser?

@Zlopez
Copy link
Contributor

Zlopez commented Mar 11, 2021

The session length is now set to 24 hours and it doesn't matter if you close your browser or not. If you have any issue with losing session when closing browser it's probably a browser issue.

@romulasry
Copy link

It would be nice if this was longer than 24hr.

@Zlopez
Copy link
Contributor

Zlopez commented Jan 27, 2023

I set the session timeout to one week. See PR. This is now deployed and running on https://release-monitoring.org

I'm closing the issue, feel free to reopen it.

@Zlopez Zlopez closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Low Priority This ticket has a low priority type.feature New feature
Projects
None yet
Development

No branches or pull requests

4 participants