Bodhi is now sending two identical emails when a package meets its karma requirement (and autopush is enabled) #1403
Comments
|
@dhgutteridge Could you link a couple or three example updates that have had this issue? I've not noticed it with my updates. |
bowlofeggs
added
the
Server CLI
|
Sure, I've listed three examples below. This only affects the emails sent, the web display of Bodhi shows everything correctly. In each case, I received two emails with the same time stamp saying the package was submitted for stable, and no email listing the final feedback that pushed it. https://bodhi.fedoraproject.org/updates/FEDORA-2017-a20103b1c8 (There's a separate issue with this one: Bodhi shows +2 karma in the summary, when +3 is required to push, yet it actually has +3 karma from the comments, and is being pushed to stable.) https://bodhi.fedoraproject.org/updates/FEDORA-2017-fab848dafc https://bodhi.fedoraproject.org/updates/FEDORA-2017-aad1da140f |
|
Actually, when looking through the message headers, the two emails don't have identical time stamps, they vary by a couple of seconds. |
|
Can you provide headers for those two that vary by a few seconds? Feel free to sanitize any info you don't want to share on the Internet. The karma count problem is known, and has been fixed on the develop branch: #829 The fix should be included with whatever release happens after 2.5.0. |
|
Sure, here are the full emails. Email one: `Received: from SN1NAM01HT154.eop-nam01.prod.protection.outlook.com The following comment has been added to the audacity-2.1.3-2.fc25 update: bodhi - 2017-04-02 15:54:33.387138 (karma: 0) To reply to this comment, please visit the URL at the bottom of this mail ================================================================================
|
|
As an update, this is still happening with Bodhi 2.5.0. |
bowlofeggs
removed
the
Server CLI
|
@dhgutteridge Does this happen with every e-mail you receive from Bodhi, or just from some? FWIW, I've not personally experienced this issue and I haven't heard from anyone else who has. If it happens for every single Bodhi comment (or for most) for you, we might be able to do some live experimenting to figure it out. |
|
@bowlofeggs: it happens consistently whenever the final necessary +1 karma is applied to a package that is presently pushed to testing and has autopush enabled, whether that karma is from me or anyone else. It's curious that no one else is seeing that, I wonder if there could be some vestigial setting in my profile that's interacting with Bodhi? (I know nothing about that.) I could sit on packages I've tested and wait to be the final +1, though that's a competitive game with some of them! |
|
@dhgutteridge Whoah this issue just happened to me, so it's not just you! I got two e-mails about https://bodhi.fedoraproject.org/updates/FEDORA-2017-054e67a81c |
|
I spent a few minutes looking at the code that adds the comment, and I don't quickly see the problem. The comment is only being added once to the update, so the code path that generates the e-mail is only being called once. The problem may be somewhere in one of these places but I'm not sure where at this point: https://github.com/fedora-infra/bodhi/blob/2.5.0/bodhi/server/models.py#L1669-L1683 |
|
Right, but technically there should be two emails sent, but they should have distinct messages in them. The first should show the comment from the person giving the +1 karma, and the second should indicate the package is being pushed to stable. Before these duplicate emails started appearing, I'd consistently get two distinct emails, but often in opposite order, so the "pushed to stable" would come first, then the "+1" comment afterwards. (A.k.a. #1210.) My guess (without looking at the code, admittedly) was what's happening instead now is that Bodhi is determining the two emails need to be sent, but when it checks what to include, the final "pushed to stable" message is the content that's returned for both. There's some sort of timing issue occurring. From looking at sample emails I've received, both of the pair are sent after the "pushed to stable" has been recorded. |
|
This is still an issue, only instead of being doubled at the point when it says "submitted for stable", it's now doubled at "submitted for batched". |
|
This is still an issue. The first message is confusing for the maintainer. Edit: The maintainer obviously is not going to react in the two seconds between the messages. But if it is important to let the maintainer know that the update can be pushed manually, even if the automatic push is later cancelled for some reason, the second message could be reworded to convey that additional info:
|
|
Another example: |
Recently, Bodhi began behaving differently: instead of sending an email listing the details of the final karmic input that caused a package to meet requirements to be pushed to stable, and then a second email indicating the package has been submitted for stable, it now sends two copies of the latter. I'm not sure if this is the result of someone trying to fix #1210, or some other cause, but it seems broken for every package I've commented on of late.
The text was updated successfully, but these errors were encountered: