Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not batch updates for branched releases #1895

Closed
bowlofeggs opened this issue Oct 15, 2017 · 3 comments
Closed

Do not batch updates for branched releases #1895

bowlofeggs opened this issue Oct 15, 2017 · 3 comments
Labels
High priority These issues are higher priority than normal RFE Requests for Enhancement

Comments

@bowlofeggs
Copy link
Contributor

It was suggested on the devel list that Bodhi should not batch updates for branched releases, because it increases the number of updates that miss the compose deadlines.

Here's the thread with a more detailed explanation:

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/PCDKEGP2UIPKSYR4F62FJFK5I362EF64/#PCDKEGP2UIPKSYR4F62FJFK5I362EF64

@bowlofeggs bowlofeggs added RFE Requests for Enhancement High priority These issues are higher priority than normal labels Oct 15, 2017
@bowlofeggs
Copy link
Contributor Author

The code around Bodhi's state machine is… let's say… spaghetti held together by duct tape. We could solve this by adding a bit more spaghetti and duct tape, but it might be easier to get it right if we fix
#1723 first. I wouldn't say that's necessarily a requirement, but I do think this could be painful and error prone without it.

@bowlofeggs
Copy link
Contributor Author

Until we have this, a reasonable workaround is for release engineering to run the bodhi-dequeue-stable CLI tool before running the final push to stable before building "significant" composes. For example, if final freeze is about to happen, it would be good to do this:

  1. Run sudo -u apache /usr/bin/bodhi-dequeue-stable.
  2. Run a mash on the branched release.

The bodhi-dequeue-stable hunts the db for all batched updates and marks them for stable. Unfortunately, it does not have any arguments, so doing this will have the side effect of also marking batched updates for stable in all other releases. In my opinion, that's a minor side effect and is worth it.

@bowlofeggs
Copy link
Contributor Author

We are dropping the batching feature in #2977 so I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High priority These issues are higher priority than normal RFE Requests for Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant