Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidetag: do not add builds which were not built in it #3778

Open
ignatenkobrain opened this issue Nov 18, 2019 · 6 comments
Open

sidetag: do not add builds which were not built in it #3778

ignatenkobrain opened this issue Nov 18, 2019 · 6 comments

Comments

@ignatenkobrain
Copy link
Contributor

With Rust, I'm tagging packages from rawhide into side tag and then performing build of actual packages. However, bodhi wants to create update with all those packages in it. I believe that we want to only suit builds which were built in that side tag.

As for non-rust case, you can tag older gcc build into the side tag, but you don't want to submit update for it.

@ignatenkobrain
Copy link
Contributor Author

@ryanlerch @bowlofeggs @sebwoj thoughts?

@bowlofeggs
Copy link
Contributor

There might be a use case for people to tag things in to a side tag with the intent to have them shipped. But I agree that if people are tagging things in just to be part of the build root, they don't necessarily want them shipped. I wonder if the side tag should get a side tag build root as well, so that people have a way to express those two different intents.

@ignatenkobrain
Copy link
Contributor Author

I don't think we want to maintain separate -build for side tags... It is just overcomplication.

If you think this is useful, I can send PR.

@bowlofeggs
Copy link
Contributor

I don't work on Bodhi anymore, so I'll defer to those who do as to whether it would be useful ☺

@cverna
Copy link
Contributor

cverna commented Nov 19, 2019

@ignatenkobrain Can you explain a little bit more why you would need to add a build that is in the rawhide tag (ie f32) in a side-tag ? If the build is in the rawhide tag it should already be available in the buildroot ?

Sorry if I am missing out something obvious but I prefer to have a clear understanding of the need :-)

@ignatenkobrain
Copy link
Contributor Author

yes, but the buildroot is for f31. so we tag crates from rawhide into f31 buildroot.

but this is very specific case, more generic one would be when you want to tag older gcc into your side tag in order to build your package. then you don't want to submit update for this older gcc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants