Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs are not added / closed (or handled at all) when using side-tags #4138

Open
pvalena opened this issue Oct 8, 2020 · 5 comments
Open

Comments

@pvalena
Copy link

pvalena commented Oct 8, 2020

I've created an update, using a side-tag.

The CVE bugs I've added manually for and I expected the rest, to be added by Bodhi.

Bugs, when not built in side-tag, are added based on "Resolves: rhbz#..." (in changelog, commits), which were both present for all relevant packages in the side-tag.

This did not happen, however.

EDIT: Bugs that I've added manually were handled correctly.


Note: the bugs are now updated to new version (some days after the update went stable; mistake on my side, shoul've closed them immediately), so I don't need to close them, but I will create new update soon, should I add those bugs manually?

@pvalena pvalena changed the title Bugs are added and not closed (handled at all), when using side-tags Bugs are not added / closed (or handled at all) when using side-tags Oct 8, 2020
@mattiaverga
Copy link
Contributor

The "Resolves: rhbz#..." thing only works for automatic updates. For normal or side-tag updates the user is supposed to manually add the bugs, since they already have to manually create the update.

@pvalena
Copy link
Author

pvalena commented Oct 26, 2020

The "Resolves: rhbz#..." thing only works for automatic updates. For normal or side-tag updates the user is supposed to manually add the bugs, since they already have to manually create the update.

Could we then turn this into RFE for WebUI? When selecting a specific side-tag, not only would the builds be filled in correctly, but also the bugs?

@pvalena
Copy link
Author

pvalena commented Oct 26, 2020

I see- this does not work for stable Fedora updates as well, then- it wouldn't be limited to side-tags, but more of a general UX enhancement.

@mattiaverga
Copy link
Contributor

This would be extremely hard as it has do be done completely in javascript and I don't even know if it's possible. In backend we use Koji's python module for most of the work.

I don't know if you noticed, but after you select some builds (or a side-tag) in the webUI form, clicking on the bug field will show you the open bugs related to the packages you selected.
Isn't that enough?

@pvalena
Copy link
Author

pvalena commented Oct 26, 2020

Yes, the menu is handy, but adding it automatically would help, actually.

If I have 14 packages (or more), I have to count the number of bugs I enter, so none would be left out (there're more opened bugs than those with update). And sometimes I need to input some CVE's, additionally, and then I have to check with the changelog of every package which CVE/bug was resolved. That did actually lead us to currently disable the monitoring, as the rest of the upgrade/update/testing is automated.

In case it can't be relayed to said python script via some ajax, I'd be glad to write it in (pure) javascript (granted there's an access to the relevant data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants