Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bodhi doesn't correctly mark updates as critpath updates for Rawhide #4177

Closed
mattiaverga opened this issue Jan 6, 2021 · 2 comments · Fixed by #4178 or #4220
Closed

Bodhi doesn't correctly mark updates as critpath updates for Rawhide #4177

mattiaverga opened this issue Jan 6, 2021 · 2 comments · Fixed by #4178 or #4220
Milestone

Comments

@mattiaverga
Copy link
Contributor

Rawhide updates are never identified as critpath updates:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-c8f0463820
https://bodhi.fedoraproject.org/updates/FEDORA-2021-d8b1203333

The problem is in the interface with PDC:

if get_critpath_components(relname, ptype, frozenset(components[ptype])):

and
'name': branch,

We query PDC for "name=f34", but rawhide in PDC is always "name=master"...

@ryanlerch
Copy link
Collaborator

This PR / Issue was included in the 5.7.0 release of Bodhi, and is now deployed in Fedora Staging. Please verify and test that this works as expected.

https://bodhi.stg.fedoraproject.org/

@mattiaverga
Copy link
Contributor Author

This is not fixed.
The Update.contains_critpath_component() class method now works as expected, but I've just realized that the automatic_updates consumer doesn't check if the new update should be marked as critpath anywhere.

We'll need to add the appropriate flag into the update data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants