Bodhi does not include scenario in generated waivers

[AdamWill]

When someone waives results on an update via Bodhi, it seems the scenario field of the generated waiver is always null, even when the result definitely has a scenario. e.g. check this waiver: https://waiverdb-web-waiverdb.app.os.fedoraproject.org/api/v1.0/waivers/9181

The scenario is null, but there would never be a update.install_default_update_live test run with no scenario. For any critpath update there will be four runs of that test with four different scenarios. I'm not sure offhand if Bodhi is generating just one waiver with a null scenario or four waivers with null scenarios in this case, but neither is really correct.

[mattiaverga]

Just one waiver with null scenario:

bodhi/bodhi/server/models.py

Lines 3102 to 3117 in 8915647

	for requirement in self._unsatisfied_requirements:
	if tests and requirement['testcase'] not in tests:
	continue
	data = {
	'subject': requirement['item'],
	'testcase': requirement['testcase'],
	'product_version': self.product_version,
	'waived': True,
	'username': username,
	'comment': comment
	}
	log.debug('Waiving test results: %s' % data)
	util.waiverdb_api_post(
	'{}/waivers/'.format(config.get('waiverdb_api_url')), data)

[AdamWill]

OK. So I think the result of that is that Greenwave considers all tests matching the testcase and item to be waived. So it's not the worst outcome for what Bodhi is trying to do, but it is technically incorrect.