Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific ACL for QA related activities #5448

Closed
mattiaverga opened this issue Aug 1, 2023 · 1 comment · Fixed by #5454
Closed

Add specific ACL for QA related activities #5448

mattiaverga opened this issue Aug 1, 2023 · 1 comment · Fixed by #5454
Labels
medium-gain medium-trouble RFE Requests for Enhancement

Comments

@mattiaverga
Copy link
Contributor

The "waive tests" and the "re-trigger tests" services are currently using the same ACLs used for allow editing an update.
I suppose we can add a new ACL to give members of qa group access to those functions, without the need to have them allowed for full editing.

@mattiaverga mattiaverga added RFE Requests for Enhancement medium-trouble medium-gain labels Aug 1, 2023
@mattiaverga
Copy link
Contributor Author

I haven't got any time to look at this, but I think there are two places that need adjustments.
First, we need a new setting to define CI allowed groups.
Then, into validators.py I think we need a new validate_ci_acls method which either returns nothing if the user is in CI allowed group or fall backs to standard validate_acls.
But I think we also have to deal with Pyramid ACLs in security.py, but I need to figure out how they work exactly with Cornice...

@mattiaverga mattiaverga linked a pull request Aug 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium-gain medium-trouble RFE Requests for Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant