Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop custom skopeo-light #5505

Closed
mattiaverga opened this issue Oct 6, 2023 · 1 comment · Fixed by #5506
Closed

Drop custom skopeo-light #5505

mattiaverga opened this issue Oct 6, 2023 · 1 comment · Fixed by #5506
Labels
Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release Refactor Issues that are a refactor to improve maintainability for Bodhi
Milestone

Comments

@mattiaverga
Copy link
Contributor

The skopeo-light script was added as a "temporary" solution while required features were being merged in skopeo:

Copy containers between registries.

This is a very limited version of the skopeo tool, but with support
for manifests lists and OCI image indexes.
https://github.com/containers/image/pull/400 will make this
unnecessary.

The only subcommand that is supported is 'copy', and the only supported image references
are Docker registry references of the form 'docker://docker-reference'.

Recent changes to the Fedora Flatpak builds highlighted that this custom script is no more compatible, meanwhile all features have been made available in the main skopeo package.
I think we can drop the script from our code. @owtaylor any objection/thought?

@mattiaverga mattiaverga added Refactor Issues that are a refactor to improve maintainability for Bodhi Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release labels Oct 6, 2023
@mattiaverga mattiaverga added this to the 8.0 milestone Oct 6, 2023
@owtaylor
Copy link
Contributor

owtaylor commented Oct 6, 2023

Sounds good to me. I think I'd suggest removing the skopeo config options too. Note that -a/--all is needed in the invocation of real skopeo so that all architectures are copied.

@mattiaverga mattiaverga linked a pull request Oct 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release Refactor Issues that are a refactor to improve maintainability for Bodhi
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants