Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting createrepo_c config per release #5521

Merged
merged 2 commits into from Nov 4, 2023

Conversation

mattiaverga
Copy link
Contributor

Fixes #5517
I've opted for defining per Release configuration or with a prefix based configuration like we do now using an external config file, rather than extending the database.

@mattiaverga mattiaverga force-pushed the compose-settings branch 5 times, most recently from dc91446 to 852f471 Compare November 1, 2023 08:51
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
@mattiaverga mattiaverga marked this pull request as ready for review November 2, 2023 07:07
@mattiaverga mattiaverga requested a review from a team as a code owner November 2, 2023 07:07
@humaton
Copy link
Member

humaton commented Nov 3, 2023

Finally got to this, trying to get it running locally.

Copy link
Member

@humaton humaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the CI fail is there just because 39 is on freeze and the latest build of libcomps-0.1.20-1.fc39 is only in testing.

I was able to run the changes locally, it looks ok.
Not sure if my review counts but ack from me.

@mattiaverga
Copy link
Contributor Author

So, the CI fail is there just because 39 is on freeze and the latest build of libcomps-0.1.20-1.fc39 is only in testing.

I was able to run the changes locally, it looks ok. Not sure if my review counts but ack from me.

Any review is always appreciated, thanks!

@mergify mergify bot merged commit eb3c570 into fedora-infra:develop Nov 4, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define compose settings per Release
2 participants