Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bodhi should reject builds done from .src.rpms #5556

Closed
AdamWill opened this issue Dec 5, 2023 · 1 comment · Fixed by #5595
Closed

Bodhi should reject builds done from .src.rpms #5556

AdamWill opened this issue Dec 5, 2023 · 1 comment · Fixed by #5595

Comments

@AdamWill
Copy link
Contributor

AdamWill commented Dec 5, 2023

I found a Rawhide update - https://bodhi.fedoraproject.org/updates/FEDORA-2023-7c0c58a874 , but it's fixed now - which was stuck in gating because greenwave was 502ing and tripping up Bodhi (see release-engineering/greenwave#218 for the greenwave side here). Kevin says it's because he mistakenly did one of the builds from a .src.rpm - regular packagers and even proven packagers can't do that, but Koji admins like Kevin can.

I'm going to try and make greenwave/Bodhi handle this situation a bit more elegantly, but also, we think Bodhi should probably just reject such builds out of hand. They shouldn't be allowed into updates. Kevin can probably provide more info on how to distinguish such a build from a 'normal' one.

@nirik
Copy link
Member

nirik commented Dec 6, 2023

You can tell from the 'Source' field of the build... for example:

Source: git+https://src.fedoraproject.org/rpms/collectd.git#fcee6f7d11dd3cea89dedb9fb9dcd648354610dc

vs

Source: collectd-5.12.0-34.fc40.src.rpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants