Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rss #558

Merged
merged 4 commits into from Sep 15, 2023
Merged

Add rss #558

merged 4 commits into from Sep 15, 2023

Conversation

phsmoura
Copy link
Contributor

Fixes noggin 1155

Proposed Changes

  • Adding RSS field in fasjson

Verification Steps

Additional Notes

Adding an RSS field to make it available for the Fedora Planet. The issue related to this pull request was opened in the Noggin repository.

@phsmoura phsmoura marked this pull request as ready for review August 11, 2023 19:34
Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Please add a news fragment as described in this doc.

@phsmoura
Copy link
Contributor Author

phsmoura commented Sep 6, 2023

Done! Thanks for reviewing it :)

Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the news fragment should contain a line that will end up in the changelog. Something like Add the rssurl field would work.

Signed-off-by: Pedro Moura <pmoura@redhat.com>
Signed-off-by: Pedro Moura <pmoura@redhat.com>
Signed-off-by: Pedro Moura <pmoura@redhat.com>
Signed-off-by: Pedro Moura <pmoura@redhat.com>
@mergify mergify bot merged commit 4636887 into fedora-infra:dev Sep 15, 2023
11 checks passed
@github-actions github-actions bot added deployed:staging This has been deployed to staging deployed:prod This has been deployed to production labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed:prod This has been deployed to production deployed:staging This has been deployed to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new field for RSS link
2 participants