Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing bindings are not removed #138

Open
abompard opened this issue Feb 28, 2019 · 1 comment
Open

Existing bindings are not removed #138

abompard opened this issue Feb 28, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@abompard
Copy link
Member

Existing bindings on the broker that have been removed from the configuration file are not deleted.
On the one hand it feels like they should be, to allow users to remove erroneous bindings without asking their broker admin. On the other hand it allows serverside declaration of bindings and just an empty [[bindings]] section in the configuration file, which avoids repeating oneself.

I still think we should remove them, the configuration already duplicates the server declarations wrt queues anyway.

@abompard abompard added the enhancement New feature or request label Feb 28, 2019
@jeremycline
Copy link
Member

It does seem like it would be nice to remove bindings. However, I don't see any way to list the existing bindings for a queue via the Pika API - I'm not sure if there's an AMQP method for that, but if there is Pika doesn't seem to have an API for it. The HTTP API does have a way to do that, but that means the client would need access to the API, and also write access to the queue and read access to the exchange (https://www.rabbitmq.com/access-control.html#permissions).

I do see how this is going to be a problem since either configuration mistakes will happen, or the needs of the app will change and there's no way in the Ansible set up currently to remove things... Or even see what bindings you currently have. I have been thinking about seeing what it would take for external auth for the management interface to work so we can have folks log in and get a "monitoring" account that's read-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants