Update the config docs and add info on configuration for public access #149
Conversation
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 95.95% 95.95%
=======================================
Files 14 14
Lines 1408 1408
Branches 189 189
=======================================
Hits 1351 1351
Misses 44 44
Partials 13 13
Continue to review full report at Codecov.
|
config.toml.example
Outdated
| ca_cert = "/etc/pki/tls/certs/ca-bundle.crt" | ||
| keyfile = "/my/client/key.pem" | ||
| certfile = "/my/client/cert.pem" | ||
| ca_cert = "/etc/fedora-messaging/fedora.cacert.pem" |
There was a problem hiding this comment.
In the other example config files, this file is called cacert.pem. Is it intended to have a different name here?
config.toml.example
Outdated
| certfile = "/my/client/cert.pem" | ||
| ca_cert = "/etc/fedora-messaging/fedora.cacert.pem" | ||
| keyfile = "/etc/fedora-messaging/fedora.key.pem" | ||
| certfile = "/etc/fedora-messaging/fedora.cert.pem" |
There was a problem hiding this comment.
In the other example config files, those files use a dash between fedora and the file type. Is it intended to have a different name here?
There was a problem hiding this comment.
No, I just adjusted the name repeatedly and they got out of sync. Fixed.
configs/fedora.toml
Outdated
| # | ||
| # This file is in the TOML format. | ||
| amqp_url = "amqps://fedora:@rabbitmq.fedoraproject.org/%2Fpublic_pubsub" | ||
| passive_declares = false |
There was a problem hiding this comment.
No, it needs to be false because in the public_pubsub vhost users create their own queues. Since the default is false I think this should be dropped here, though. Looked like I dropped it from the stg config, but not here.
There was a problem hiding this comment.
Right, I mixed it up. Do you think there may be errors trying to declare the exchange?
There was a problem hiding this comment.
It works fine in staging. I'm having an issue in production that looks like a proxy problem - the initial TCP handshake isn't completing, but it's the same configuration.
| # This file is in the TOML format. | ||
| amqp_url = "amqps://fedora.stg:@rabbitmq.stg.fedoraproject.org/%2Fpublic_pubsub" | ||
| callback = "fedora_messaging.example:printer" | ||
|
|
There was a problem hiding this comment.
Should we set passive_declares to true here?
jeremycline
force-pushed
the
config-docs
branch
from
e215792
to
c38f0ff
Compare
This shuffles the example configuration file around so that each section of configuration in the example matches up with the documentation in terms of order. It also inlines the example into the Sphinx documentation. Signed-off-by: Jeremy Cline <jcline@redhat.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
Add credentials and configurations for both the staging and production virtual hosts provided by Fedora. Document their usage. Signed-off-by: Jeremy Cline <jcline@redhat.com>
This has a couple small commits which I didn't feel was worth the effort of breaking out into numerous PRs, but all center around making the configuration documentation clearer, including how to configure access to the Fedora broker.