Twisted legacy logging does not accept format parameters #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
abompard
force-pushed
the
fix-twisted-logging
branch
from
ef36981
to
620740f
Compare
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 13 13
Lines 1312 1312
Branches 158 158
=======================================
Hits 1252 1252
Misses 45 45
Partials 15 15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have unformatted logs, like:
Stopping AMQP consumer {tag} for queue {q}: {e}. This commit fixes it.