New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tomllib from the standard library on Python 3.11 #274
Conversation
FTR tomli is being added to epel8, so this could be made a bit simpler. |
OK, do you want to rework it Miro? |
Done. |
Codecov ReportBase: 88.53% // Head: 88.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #274 +/- ##
===========================================
+ Coverage 88.53% 88.76% +0.23%
===========================================
Files 14 13 -1
Lines 1186 1193 +7
Branches 173 174 +1
===========================================
+ Hits 1050 1059 +9
+ Misses 123 121 -2
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The mocks got unhappy, trying to fix that. |
This comment was marked as resolved.
This comment was marked as resolved.
This turned out to be more tedious than I anticipated. The tests are very unforgiving to slight implementation changes :( Anyway, I think I cracked it and
Passes. Let me know if I shall squash or if you'd rather squash when merging. I'd like you to see my train of thought when reviewing it, so not squashing yet. |
Yeah, got it, thanks. Please squash. Sorry it ended up more painful that it should have been. |
Fallback to tomli otherwise. See https://fedoraproject.org/wiki/Changes/DeprecatePythonToml Signed-off-by: Miro Hrončok <miro@hroncok.cz>
Squashed, signed off. |
The code would be slightly easier if we fell back to tomli, but I kept using toml as this code also targets EL 8.
See https://fedoraproject.org/wiki/Changes/DeprecatePythonToml