Add an example consumer callback #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According the documentation, to use the @<property>.setter notation, the decorated functions all need the same name[0]. Without this, trying to set the property fails with an AttributeError. [0] https://docs.python.org/3/library/functions.html#property Signed-off-by: Jeremy Cline <jcline@redhat.com>
There's a slight difference in the JSON dumping format between Python 2 and 3.4+[0]. The default separators change if indent is not None. This sets the separators explicitly to the Python 3 default so Python 2 looks the same. This is mostly so writing tests for expected output isn't so annoying. [0] https://docs.python.org/3/library/json.html#json.dump Signed-off-by: Jeremy Cline <jcline@redhat.com>
This is useful just as an example, and also because it's nice to have an importable callback that conforms to the API handy for testing purposes. Signed-off-by: Jeremy Cline <jcline@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 88.59% 88.93% +0.33%
==========================================
Files 10 11 +1
Lines 763 768 +5
Branches 105 105
==========================================
+ Hits 676 683 +7
+ Misses 60 58 -2
Partials 27 27
Continue to review full report at Codecov.
|
abompard
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself regularly wanting a callback available to test with, so this just adds a simple printer callback. This also led to the discovery of a few small issues when I wrote a test, so those have been fixed as well.