Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in meeting minutes to full logs are wrong in modal view #53

Closed
mattdm opened this issue Jul 30, 2015 · 4 comments
Closed

Links in meeting minutes to full logs are wrong in modal view #53

mattdm opened this issue Jul 30, 2015 · 4 comments
Labels
T: bug Something isn't working

Comments

@mattdm
Copy link

mattdm commented Jul 30, 2015

The meeting minutes have links to the full logs, both at the top and inline for various topics. These all result in 404 errors.

I think ideally they should go to that full log within møte.

@cydrobolt
Copy link
Contributor

Yes, we should use BeautifulSoup to replace those links ideally. Perhaps some kind of regex will also be needed.

@cydrobolt cydrobolt added the T: improvement Improves on something that already exists label Aug 13, 2015
@cydrobolt cydrobolt changed the title Links in meeting minutes to full logs are wrong Links in meeting minutes to full logs are wrong in modal view Aug 14, 2015
@sanjayankur31
Copy link

I don't think this is an enhancement, it's more a defect at the time being. :/

Here are some more details: On this page: ​https://meetbot.fedoraproject.org/fedora-meeting/2015-09-02/workstation.2015-09-02-14.01.html/

"full logs" links to: ​https://meetbot.fedoraproject.org/fedora-meeting/2015-09-02/workstation.2015-09-02-14.01.html/workstation.2015-09-02-14.01.log.html

but the actual link, (as puiterwijk later informed me me) should be: ​https://meetbot-raw.fedoraproject.org/fedora-meeting/2015-09-02/workstation.2015-09-02-14.01.log.html

@cydrobolt
Copy link
Contributor

@sanjayankur31, the bug you are referring to is actually #60, although this bug is also annoying. Tagging as bug instead of enhancement.

@cydrobolt cydrobolt added T: bug Something isn't working and removed T: improvement Improves on something that already exists labels Sep 3, 2015
@cydrobolt
Copy link
Contributor

Fixed in fa635fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants