Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase the usernames when users want to reset their password #573

Closed
abompard opened this issue Apr 6, 2021 · 7 comments · Fixed by #617
Closed

Lowercase the usernames when users want to reset their password #573

abompard opened this issue Apr 6, 2021 · 7 comments · Fixed by #617
Labels
bug Something isn't working EasyFix Good for newcomers S Small (~5 hours of work)
Projects

Comments

@abompard
Copy link
Member

abompard commented Apr 6, 2021

If a user uses a mixed-case username to request a password change token, the lock file will be created with this mixed-case username. The IPA API call will succeed because IPA automatically lowercases usernames. But when the lock needs to be removed in the next part of the process, it will try to remove the lowercase version, not find it, and traceback.

We should lowercase the user input before creating the PasswordResetLock instance.

@abompard abompard added bug Something isn't working EasyFix Good for newcomers S Small (~5 hours of work) labels Apr 7, 2021
@abompard abompard added this to Backlog in AAA Apr 7, 2021
@akanshak984
Copy link

@abompard I would like to work on this. Can you guide me on how to reproduce this on my local?

@abompard
Copy link
Member Author

abompard commented Apr 9, 2021

Sure! Our contributor guide is here: https://noggin-aaa.readthedocs.io/en/latest/contributing.html
But it may be out of date in places so if it does not work feel free to ping me here or in IRC in #fedora-aaa.
Thanks for your help! :-)

@akanshak984
Copy link

Sure! Our contributor guide is here: https://noggin-aaa.readthedocs.io/en/latest/contributing.html
But it may be out of date in places so if it does not work feel free to ping me here or in IRC in #fedora-aaa.
Thanks for your help! :-)

Hi @abompard I'm unable to set this up on my local using the link you provided, and I have no idea how to ping you (or anyone) in IRC.
Attaching below the screenshot for the error i'm getting.
system details: Ubuntu 18.04.3 LTS

Screenshot from 2021-04-09 17-34-58

@abompard
Copy link
Member Author

abompard commented Apr 9, 2021

Ah, we haven't tested development on Ubuntu, since Noggin is the web frontend for the authentication system in Fedora (and soon OpenSuSE I think).
You're apparently missing a vagrant provider, it should be in the deb-equivalent packages of libvirt and vagrant-libvirt. I don't know if Ubuntu has equivalents of vagrant-hostmanager and vagrant-sshfs but that's likely. I don't know how the packages are named though.

@gridhead
Copy link
Member

gridhead commented Apr 10, 2021

@akanshak984, please try installing VirtualBox on your local environment. Here are some links that you may find helpful.

(That is if you decide VirtualBox to be your default provider. You can pick something else as well.)

@akanshak984
Copy link

@akanshak984, please try installing VirtualBox on your local environment. Here are some links that you may find helpful.

(That is if you decide VirtualBox to be your default provider. You can pick something else as well.)

@t0xic0der I have installed VirtualBox, Now when I try to run Vargant Box I get this

Screenshot from 2021-04-10 12-52-24

@akanshak984
Copy link

akanshak984 commented Apr 12, 2021

Ah, we haven't tested development on Ubuntu, since Noggin is the web frontend for the authentication system in Fedora (and soon OpenSuSE I think).
You're apparently missing a vagrant provider, it should be in the deb-equivalent packages of libvirt and vagrant-libvirt. I don't know if Ubuntu has equivalents of vagrant-hostmanager and vagrant-sshfs but that's likely. I don't know how the packages are named though.

Hi @abompard , I have tried to set-up the development enviornment on Fedora too.. But I'm still unable to do that.
When I run vagrant up, it gives me error in TASK [noggin : Enroll system as IPA client] ************************************ which i'm unable to understand. Also the error is quite large, so i cannot post here.
What should I do?

Kindly advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EasyFix Good for newcomers S Small (~5 hours of work)
Projects
No open projects
AAA
  
Backlog
Development

Successfully merging a pull request may close this issue.

3 participants