Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fedora-specific defaults from Noggin #949

Merged
merged 1 commit into from Jun 10, 2022

Conversation

Conan-Kudo
Copy link
Contributor

This makes it easier for third-party (non-Fedora) deployments of Noggin to work.

@Conan-Kudo Conan-Kudo force-pushed the fix-defaults branch 6 times, most recently from 76f0371 to c1cfc8a Compare June 9, 2022 09:53
Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The news type should be bic (backwards incompatible), because it's a default configuration change.

Also please allow changes to your branch so that mergify can rebase. Thanks!

This makes it easier for third-party (non-Fedora) deployments of Noggin to work.

Signed-off-by: Neal Gompa <neal@gompa.dev>
@Conan-Kudo
Copy link
Contributor Author

@abompard Done.

@mergify mergify bot merged commit 42e7097 into fedora-infra:dev Jun 10, 2022
@Conan-Kudo Conan-Kudo deleted the fix-defaults branch June 10, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants