pkgdb-admin should check that a review was not approved by the packager requesting a new package

[tyll]

It is not allowed to review ones own package

[pypingou]

I think that's already there, isn't it?

[tyll]

currently it only checks that the package was approved by a packager afaics. But it can be added easily once #55 was merged, since both would touch the same code. However, I am also wondering whether it makes sense to check this better in pkdbd directly - also some other checks could be enforced direclty in pkdbdb and maybe are already, so they do not need to be checked twice.

[pypingou]

You mean this? fedora-infra/pkgdb2#281

But this is only valid if the user provides the ticket number and click on the populates button

[tyll]

AFAICS there is no check about who set the review flag to "+". If the checks in that code are only performed optionally, then they should be made mandatory btw. see for example https://bugzilla.redhat.com/show_bug.cgi?id=1280422 which was accidently approved without being properly reviewed.

[pypingou]

I disagree about having pkgdb making these checks, I believe this is the work of pkgdb-admin and I still want to make pkgdb somewhat agnostic so that other organizations can also use it.