Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the way to file pull requests #558

Merged
merged 1 commit into from Apr 24, 2023
Merged

Document the way to file pull requests #558

merged 1 commit into from Apr 24, 2023

Conversation

Zlopez
Copy link
Contributor

@Zlopez Zlopez commented Apr 21, 2023

There is now possibility to file pull requests thanks to the Packit Team and the-new-hotness. Let's document this in the-new-hotness documentation, so users know about it.

@softwarefactory-project-zuul
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/4498ccd8408b492dbe014909fb773dec

✔️ fi-tox-mypy SUCCESS in 11m 44s
✔️ fi-tox-lint SUCCESS in 11m 24s
✔️ fi-tox-format SUCCESS in 11m 49s
❌ fi-tox-python38 FAILURE in 12m 03s
❌ fi-tox-python39 FAILURE in 11m 53s
❌ fi-tox-python310 FAILURE in 9m 33s
❌ fi-tox-docs FAILURE in 11m 25s
✔️ fi-tox-bandit SUCCESS in 11m 36s
❌ fi-tox-diff-cover FAILURE in 12m 56s

nforro
nforro reviewed Apr 21, 2023
View reviewed changes
docs/user-guide.rst Outdated Show resolved Hide resolved
nforro
nforro reviewed Apr 21, 2023
View reviewed changes
docs/user-guide.rst Outdated Show resolved Hide resolved
nforro
nforro reviewed Apr 21, 2023
View reviewed changes
docs/user-guide.rst Outdated Show resolved Hide resolved
nforro
nforro reviewed Apr 21, 2023
View reviewed changes
docs/user-guide.rst Outdated Show resolved Hide resolved
nforro
nforro reviewed Apr 21, 2023
View reviewed changes
docs/user-guide.rst Outdated Show resolved Hide resolved
@Zlopez
Copy link
Contributor Author

Zlopez commented Apr 21, 2023

@nforro Thanks for the review, all your suggestion should be now added, but I first need to fix the tests.

nforro
nforro approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@nforro nforro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@softwarefactory-project-zuul
Copy link

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/c16c4f7625fb49b5b04ef588c05aea52

✔️ fi-tox-mypy SUCCESS in 15m 19s
✔️ fi-tox-lint SUCCESS in 14m 41s
✔️ fi-tox-format SUCCESS in 14m 52s
❌ fi-tox-python38 FAILURE in 15m 19s
❌ fi-tox-python39 FAILURE in 15m 24s
❌ fi-tox-python310 FAILURE in 11m 15s
❌ fi-tox-docs FAILURE in 15m 12s
✔️ fi-tox-bandit SUCCESS in 14m 42s
❌ fi-tox-diff-cover FAILURE in 16m 09s

lachmanfrantisek
lachmanfrantisek approved these changes Apr 21, 2023
View reviewed changes
Copy link

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@Zlopez
Document the way to file pull requests
e0b68d4 
There is now possibility to file pull requests thanks to the Packit Team and
the-new-hotness. Let's document this in the-new-hotness documentation, so users
know about it.

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/6006bca5b6b0465bba8f784f12e91e66

✔️ fi-tox-mypy SUCCESS in 11m 20s
✔️ fi-tox-lint SUCCESS in 10m 47s
✔️ fi-tox-format SUCCESS in 11m 04s
✔️ fi-tox-python38 SUCCESS in 11m 25s
✔️ fi-tox-python39 SUCCESS in 11m 31s
✔️ fi-tox-python310 SUCCESS in 11m 21s
✔️ fi-tox-docs SUCCESS in 11m 06s
✔️ fi-tox-bandit SUCCESS in 11m 06s
✔️ fi-tox-diff-cover SUCCESS in 12m 30s

@Zlopez Zlopez merged commit 339f300 into fedora-infra:master Apr 24, 2023
2 checks passed
@Zlopez Zlopez deleted the packit_update branch April 24, 2023 07:48
TomasTomecek
TomasTomecek approved these changes Apr 24, 2023
View reviewed changes
Copy link

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTomecek TomasTomecek TomasTomecek approved these changes

@nforro nforro nforro approved these changes

@lachmanfrantisek lachmanfrantisek lachmanfrantisek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zlopez @TomasTomecek @nforro @lachmanfrantisek