Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the 189 patch trailer is not in the spec, don't add it #16

Open
hroncok opened this issue Mar 8, 2022 · 1 comment
Open

When the 189 patch trailer is not in the spec, don't add it #16

hroncok opened this issue Mar 8, 2022 · 1 comment

Comments

@hroncok
Copy link
Member

hroncok commented Mar 8, 2022

In here, https://src.fedoraproject.org/rpms/python3.6/c/ca58751035496b75ebc1a5dd46ebdbecca825a14?branch=rawhide @frenzymadness removed:

-# The following versions of setuptools/pip are bundled when this patch is not applied.
-# The versions are written in Lib/ensurepip/__init__.py, this patch removes them.
-# When the bundled setuptools/pip wheel is updated, the patch no longer applies cleanly.
-# In such cases, the patch needs to be amended and the versions updated here:
-%global pip_version 18.1
-%global setuptools_version 40.6.2

At that time, I have not considered the removal a problem. It made sense.

However, now @stratakis adds a new patch to python3.6 and improtpatches add this blurb back.

Maybe importpatches could skip adding this blurb when:

  • patch 189 is unchanged
  • the blurb was not there before improtpatches run

WDYT?

@encukou
Copy link
Member

encukou commented Mar 8, 2022

Sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants