Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to tox-dev and v4 support #41

Closed
gaborbernat opened this issue Aug 29, 2021 · 10 comments · Fixed by #42
Closed

Migrate to tox-dev and v4 support #41

gaborbernat opened this issue Aug 29, 2021 · 10 comments · Fixed by #42
Assignees

Comments

@gaborbernat
Copy link

Hello, would you consider moving the project under the tox-dev umbrella? See documentation under https://tox.readthedocs.io/en/rewrite/plugins.html#adoption-of-a-plugin-under-tox-dev-github-organization

Furthermore, tox v4 is getting ready and we'd like to make sure this plugin is supported from day 1, we're collecting feature gaps for this under tox-dev/tox#1974. Would be great if you could join our development chat under https://discord.gg/tox so we can assist with this. If you do so please drop in a line in the #plugin chat with the name of the repository you maintain. Thanks!

@hroncok
Copy link
Member

hroncok commented Aug 30, 2021

Hello @gaborbernat: I've been neglecting tox v4 migration for a while, but it is definitively on my radar. Thanks for the offer to help.

As for the tox-dev umbrella, if only this could have been under both organizations, I'd definitively said yes, but moving to tox-dev also means moving away from fedora-python and I am not so sure if we want that. The project is tightly coupled with Fedora's packaging and follows the Fedora's Code of Conduct. I'll think about it and discuss it with others. Thnaks for he offer!

@gaborbernat
Copy link
Author

Hello, migrating is fully optional 😊so no pressure 🍺

@hroncok
Copy link
Member

hroncok commented Aug 31, 2021

Do you have some rough idea when tox 4 reaches betas and rcs? I'd like to prioritize this accordingly.

@gaborbernat
Copy link
Author

It can go beta today and start iterating on a release from there. How long that will last will depend on how much change we have to do for accommodating plugins and how many bugs our beta testers find (release blockers are https://github.com/tox-dev/tox/milestone/7).

@ssbarnea
Copy link
Contributor

ssbarnea commented Feb 6, 2022

@hroncok tox 4 beta was just launched this morning and guess what package broke it... As first measure I would release a patch that would require tox<4.0 and start reviewing the #42 for integration.

@hroncok
Copy link
Member

hroncok commented Feb 6, 2022

Yeah, when I saw the beta release, I was thinking we need to pin.

@hroncok
Copy link
Member

hroncok commented Feb 6, 2022

#48

@jabbera
Copy link

jabbera commented Dec 10, 2022

I know this is old, but we have a stable tox 4 out now. Can we get this update pushed?

@hroncok
Copy link
Member

hroncok commented Dec 10, 2022

That is the plan. We are carefully evaluating the impact on Fedora packages. See https://src.fedoraproject.org/rpms/python-tox/pull-request/84#comment-123712

@hroncok
Copy link
Member

hroncok commented Dec 14, 2022

I've just released 0.0.10 with tox 4 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants