Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Remove GNOME Tour from base image #252

Closed
A6GibKm opened this issue Apr 11, 2022 · 17 comments
Closed

[Request] Remove GNOME Tour from base image #252

A6GibKm opened this issue Apr 11, 2022 · 17 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@A6GibKm
Copy link

A6GibKm commented Apr 11, 2022

Given that one can use a Flatpak from the fedora repository and have it preinstalled on new installs, one can consider removing it from the base image.

@tpopela
Copy link
Contributor

tpopela commented Apr 20, 2022

This is definitely a valid request, but there isn't a GNOME Tour Fedora Flatpak yet - I will try to create it in the next few weeks (or actually contributions are welcome) when I will work on Fedora 36 Flatpak Runtime.

@travier travier added enhancement New feature or request good first issue Good for newcomers labels Apr 20, 2022
@bobslept
Copy link

Hi there. In order to help out I've tried to create a flatpak of gnome-tour. It's my first flatpak but it worked out. Currently it's made on Fedora 35. But I would think that changing it to Fedora 36 would be rather easy by replacing the [f35] with [f36], when the runtime is ready.

After building and installing it, I was able to run it with flatpak run org.gnome.Tour and it worked perfect.
Please let me know if I can help and which steps to take from here.

-- Bob

gnome-tour.yaml

---
document: modulemd
version: 2
data:
  summary: GNOME Tour and Greeter
  description: A guided tour and greeter for GNOME.
  license:
    module:
    - GPLv3+
    - CC-BY-SA
  dependencies:
  - buildrequires:
      flatpak-common: [f35]
      flatpak-runtime: [f35]
      platform: [f35]
    requires:
      flatpak-common: [f35]
      flatpak-runtime: [f35]
      platform: [f35]
  profiles:
    default:
      rpms:
      - gnome-tour
  components:
    rpms:
      gnome-tour:
        rationale: Application package
        ref: f35
...

container.yaml

compose:
    modules:
    - gnome-tour:master
flatpak:
    id: org.gnome.Tour
    branch: master
    command: gnome-tour
    finish-args: |-
        --share=ipc
        --socket=x11
        --socket=wayland
        --device=dri

@A6GibKm
Copy link
Author

A6GibKm commented May 12, 2022

Please use fallback-x11 instead of x11 on gtk flatpak apps

@tpopela
Copy link
Contributor

tpopela commented May 12, 2022

Thank you @bobslept ! Do you have a Fedora account? If so, can you actually create a build there by using the following documentation - https://docs.fedoraproject.org/en-US/flatpak/tutorial/ ? But honestly I would start with that in +- 2 weeks when the F36 runtime is ready and we upstream some fedmod changes, because right now fedmod from Fedora repositories is broken in many cases. I can ping you back here when things will be ready.

@bobslept
Copy link

bobslept commented May 12, 2022

Hi @tpopela, I do have a Fedora account, but I don't know it's a correct one for this kind of work. Yes fedmod didn't work out for me either when I tried it so I just skipped that part and did it by hand. Alright let's wait a few weeks then and pick this up when I receive your ping.

Edit:
I was just thinking. Can getting this in flatpak lead to a problem where lets say for example a fresh F35 install gets the gnome-tour flatpak version from F36 which shows slides for specific features introduced by the latest version. Because there will be only one flatpak version around?

@A6GibKm thank you, I will take a note of that.

@travier
Copy link
Member

travier commented May 13, 2022

https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/ should help.

Edit: I was just thinking. Can getting this in flatpak lead to a problem where lets say for example a fresh F35 install gets the gnome-tour flatpak version from F36 which shows slides for specific features introduced by the latest version. Because there will be only one flatpak version around?

That's a good point. Maybe this is not a good idea in the end 😕.

@travier
Copy link
Member

travier commented May 13, 2022

Or maybe this one: https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process_for_New_Contributors/

@bobslept
Copy link

I found a f36 runtime on koji and installed it locally on F35 machine. Then I build the flatpak against it. Just for testing. This is the result.
image
Which does not make sense on a F35 system. So indeed it's probably not a good idea in the end.

@travier
Copy link
Member

travier commented May 16, 2022

I'll go ahead and close this one. While it would be interesting to have that packaged as a Flatpak, right now this would not be doing what we want. Maybe we can revisit this later.

@travier travier closed this as completed May 16, 2022
@felipeborges
Copy link

I proposed an alternative to this, which would involve teaching GNOME Tour to display different versions of its content. I wonder what upstream developers will think of it, but it could be that one could pass a version argument to GNOME Tour and have it display the content for that version. See https://gitlab.gnome.org/GNOME/gnome-tour/-/issues/52

@bilelmoussaoui
Copy link

Note the version number comes from /etc/os-release. We don't hardcode that. Regarding the content of the tour, currently it doesn't seems to be tied to a specific release iirc

@felipeborges
Copy link

felipeborges commented May 16, 2022

Note the version number comes from /etc/os-release. We don't hardcode that. Regarding the content of the tour, currently it doesn't seems to be tied to a specific release iirc

My worry for the content would be of Tour promoting new features that aren't available in older versions. For example one would add a new gesture or the overview would change significantly from one version to another, app icon updates, etc...

@travier travier reopened this May 17, 2022
@travier
Copy link
Member

travier commented May 17, 2022

Re-opening given the discussion.

@travier
Copy link
Member

travier commented May 17, 2022

Would be great if the Tour app could read the version from somewhere and then show intro pages to the user depending on that.

@JamesBelchamber
Copy link

Is there any reason we can't move GNOME Tour from the base image to a pre-installed layer? This would make it trivial to remove by anyone savvy enough to rpm-ostree remove gnome-tour.

@travier
Copy link
Member

travier commented May 25, 2022

Is there any reason we can't move GNOME Tour from the base image to a pre-installed layer? This would make it trivial to remove by anyone savvy enough to rpm-ostree remove gnome-tour.

There is no way to setup pre-installed layers right now. Someone would have to work on it.

@travier
Copy link
Member

travier commented May 15, 2023

Thinking about this more, I've realizes that letting users remove GNOME Tour would mean that if they create a new user later, it won't show the tour, which is not ideal.

Overall this could be achieved but I'm not sure this is worth the gain so I'll close this for now.

@travier travier closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants