GRUB errors out on boot due to TPM module errors

[allaeddineomc]

This issue tracker is intended only for Silverblue specific issues. We would like to ask you to try to reproduce the issue on a relevant Fedora Workstation release. If you will be able to reproduce there, then please report it in Red Hat Bugzilla (see How to file a bug) or in upstream (preferred for GNOME projects) and not in this issue tracker.

Describe the bug
grub errors out on boot with a tpm error after yesterday's update for f37 , the error was present for some time in f35

To Reproduce
rpm-ostree update
reboot

Expected behavior
boots with no errors

Screenshots
If applicable, add screenshots to help explain your problem.

OS version:

State: idle
BootedDeployment:
● fedora:fedora/37/x86_64/silverblue
                  Version: 37.20220917.n.0 (2022-09-17T08:40:50Z)
               BaseCommit: b8c2ee6d796392558966f93a665c46fc681bf0033660234d166556c8c7641170
             GPGSignature: Valid signature by ACB5EE4E831C74BB7C168D27F55AD3FB5323552A

Additional context
a quick workaround (not really a solution) :
on boot keep smashing up or down arrows for the grub menu to show
press "c"
type these commands
rmmode tpm
normal
the menu will show again but now it will boot properly

[allaeddineomc]

today's update updated grub , the issue is still present

[travier]

This is likely an upstream GRUB bug or a firmware bug. Please file it in Bugzilla.

[allaeddineomc]

can't access my fedora account anymore , please someone else report it

[travier]

It's likely specific to your hardware so I would recommend that you create a new account to report it.

[allaeddineomc]

bug reported on bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=2128485
i guess this issue can be closed here

[travier]

Closing as the next steps will happen in Bugzilla.

[travier]

Workaround until this is fixed in GRUB:

$ cat /etc/grub.d/02_notpm 
#!/usr/bin/sh -e
cat << EOF
rmmod tpm
EOF

Then update the system and the GRUB config will be regenerated.

[travier]

Error message to help with searches:

../../grub-core/commands/efi/tpm.c:148:Unknown TPM error.

[rickatnight11]

The Bugzilla issue got closed incorrectly as a kernel fix, so not sure what the next steps here are for an actual fix.

[travier]

The best path is to reply in the BZ that this is not fixed and I'll re-open it.

[travier]

Note that this is marked "fixed" in F38.

[rickatnight11]

Thanks, @travier! I did comment on the BZ, which is still closed. Where do you see this marked as fixed in F38?

[travier]

https://bugzilla.redhat.com/show_bug.cgi?id=2128485#c9 mentions F37. Did you try with Fedora 38? Note that the bootloader is also not updated yet in Silverblue. See: #120

[rickatnight11]

I've only been using and experiencing this issue on Fedora Silverblue 37. 38 isn't out yet, to my knowledge. I don't see any reference to where this issue is fixed in 38. I just have the above BZ reporting it for 37, then marking it closed as resolved as of a specific kernel version, which doesn't seem correct.

[jlaham]

FWIW, still seeing this with f38.

State: idle
Deployments:
● fedora:fedora/38/x86_64/silverblue
                  Version: 38.20230513.0 (2023-05-13T00:46:58Z)
               BaseCommit: 0cb2293657eaba7b89c1c62d74fd69f6c7c42fe31b0df16fbae8708202377ab0
             GPGSignature: Valid signature by 6A51BBABBA3D5467B6171221809A8D7CEB10B464

[travier]

Note that this will likely not be fixed until we have #120.

Since that's on our end now, I'll re-open this issue.

[rickatnight11]

I'm not sure why this blocks on implementing bootupd and removing ostree-grub2. I believe this needs to be fixed in the tpm module in grub2 (I think it doesn't handle the older TPM on some Asus Zenbooks). Can we get the related bugzilla re-opened?

[travier]

If the bug is fixed in a newer GRUB version then we need bootloader updates. Silverblue systems don't update the bootloader right now which is why we need bootupd.

[rickatnight11]

Ah, that makes sense for this issue tracker. I've learned how to update the bootloader, myself, and new installs would at least benefit before bootupd is implemented.

It's not clear to me that the core grub issue is being tracked, though, since the bugzilla was closed. Are you able to reopen it?

[travier]

Can you verify that this is still an issue from a fresh Fedora 38 installation and comment in the Bugzilla?

[rickatnight11]

Yes, confirmed it's still an issue and commented on the bugzilla.

[travier]

I think this is still an issue on F39 but if someone affected could confirm that would be great. Thanks

[rickatnight11]

Can confirm, still on f39.