Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamburger menu items have flags that go nowhere. #260

Open
WardCunningham opened this issue Jan 23, 2020 · 2 comments
Open

Hamburger menu items have flags that go nowhere. #260

WardCunningham opened this issue Jan 23, 2020 · 2 comments

Comments

@WardCunningham
Copy link
Member

The Hamburger button creates a ghost page of Reference plugins who's link label brings up a useful page from within a plugin's About pages. It does not bring up the entry About page for the plugin but it could. Right now clicking the Reference's flag goes nowhere. Maybe this should bring up the entry About page?

image

Some plugins offer a variety of interesting pages that can all be found from the entry About page. Rather than redundantly list all of these in the hamburger menu, let's just link the flag to the entry About page so that the full repertoire of services become available.

This would be a small deviation from what one usually expects of the flag behavior but it is already different and useless too.

The Reference plugin might not be configurable enough right now to encode this behavior. If not we can always supplement the Item json with enough clues to enable the desired rendering into html.

@WardCunningham WardCunningham changed the title Hamburger menu items have items with flags that go nowhere. Hamburger menu items have flags that go nowhere. Jan 23, 2020
@WardCunningham
Copy link
Member Author

Here is where the hamburger button constructs the Item json with fields, title, slug, type and text.

title,
slug,
type: "reference",
text: (if error then error.msg else data?.story[0].text) or ""

@WardCunningham
Copy link
Member Author

Here is where the Reference plugin (part of wiki-client) translates these parameters into html.

<p>
<img class='remote'
src='#{wiki.site(site).flag()}'
title='#{site}'
data-site="#{site}"
data-slug="#{slug}"
>
#{resolve.resolveLinks "[[#{item.title or slug}]]"}
#{resolve.resolveLinks(item.text)}
</p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant