Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML markup on initial page load #93

Closed
paul90 opened this issue Jan 28, 2015 · 1 comment
Closed

HTML markup on initial page load #93

paul90 opened this issue Jan 28, 2015 · 1 comment

Comments

@paul90
Copy link
Member

paul90 commented Jan 28, 2015

The server rendered page displays content which has been escaped. For example:

  <body>
    <section class='main'>
      <div class='page' id=welcome-visitors  data-server-generated=true>&lt;div class="twins"&gt;&lt;p&gt;&lt;/p&gt;&lt;/div&gt;
&lt;div class="header"&gt;&lt;h1&gt;&lt;a href="/" style="text-decoration: none"&gt;&lt;img  height="32px" src="/favicon.png"&gt;&lt;/a&gt; Welcome Visitors&lt;/h1&gt;&lt;/div&gt;
&lt;div class="story"&gt;&lt;div class="item paragraph"&gt;&lt;p&gt;Welcome to the <a class="internal" href="/federated-wiki.html" data-page-name="federated-wiki" title="">Federated Wiki</a>.&lt;/p&gt;&lt;/div&gt;
&lt;div class="item error"&gt;&lt;p&gt;markdown&lt;/p&gt;&lt;/div&gt;
&lt;div class="item paragraph"&gt;&lt;p&gt;<a class="internal" href="/paul-rodwell.html" data-page-name="paul-rodwell" title="">Paul Rodwell</a>&lt;/p&gt;&lt;/div&gt;
&lt;div class="item error"&gt;&lt;p&gt;markdown&lt;/p&gt;&lt;/div&gt;
@paul90
Copy link
Member Author

paul90 commented Jan 28, 2015

Problem looks to be caused by calling wiki.resolveLinks (from the client) on the rendered page. A fairly recent change to resolveLinks added content sanitization, with escaping being the default.

A better solution will be to call resolveLinks on each page item, rather than the page as a whole.

paul90 added a commit that referenced this issue Jan 29, 2015
@paul90
fix for #93
f3ac48d
WardCunningham added a commit that referenced this issue Jan 30, 2015
@WardCunningham
Merge pull request #94 from fedwiki/paul90/issue93
50a8238 
fix for #93, and trying harder to server render story items
@paul90 paul90 closed this as completed Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paul90