Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS 1.0 no consistent GUID #11

Closed
jangernert opened this issue Jan 22, 2020 · 2 comments · Fixed by #13
Closed

RSS 1.0 no consistent GUID #11

jangernert opened this issue Jan 22, 2020 · 2 comments · Fixed by #13

Comments

@jangernert
Copy link
Contributor

The RSS 1.0 parser uses the auto generated GUID from Entry::default(). This means parsing a feed a second time for new articles results in duplicate articles.
One could use the url to check for duplicates. But imo it would be nicer if feed_rs generated a consistent id for each item. Probably based on the url of the article.

@markpritchard
Copy link
Contributor

I was wondering whether it would be a downstream user of feed-rs that would handle this logic, but since the spec doesn't define a unique ID at all in RSS 1.0 its reasonable to do something sensible in feed-rs. I'll push up a fix.

@jangernert
Copy link
Contributor Author

Having the users of feed_rs handle the problem would also be acceptable. But in that case the ID should be None. Having a random string is quite misleading.
Anyway thank you for the fix =)

This was referenced Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants