Heavy refactoring of the cloud app #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matzew Mind reviewing? |
josemigallas
force-pushed
the
master
branch
2 times, most recently
from
a7281db
to
dceb7f2
Compare
|
👍 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
App auth (pushID and masterSecret) are no longer required via HTTP. Now hey are to be provided in a json file called "app-auth.json" when deployed. This way the credentials are safe.
Refactoring: decoupling of models (message, options, criteria, config) for better reuse. API wrappers for both fh.push and UPS RestAPI so all calls are transparent for the endpoint logic. New route names (push/fh and push/ups instead of push and push-ups).
Unit testing